AGENT-299: Set mode 0644 on containers.conf#6171
Merged
openshift-merge-robot merged 1 commit intoopenshift:agent-installerfrom Jul 26, 2022
Merged
AGENT-299: Set mode 0644 on containers.conf#6171openshift-merge-robot merged 1 commit intoopenshift:agent-installerfrom
openshift-merge-robot merged 1 commit intoopenshift:agent-installerfrom
Conversation
If the file /etc/containers/containers.conf is not world-readable, starting the podman API service fails. If nothing else, this leaves a lot of misleading junk in the journal logs. In practice, only the agent installation method is populating this file, but in principle this is the right mode wherever it is used. We are creating the file to work around a podman configuration bug, so it is entirely possible that other installation methods will also use it in the future. Therefore the fix is in the bootstrap ignition population method.
Contributor
|
/lgtm |
Member
Author
|
/assign @patrickdillon |
Contributor
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the file /etc/containers/containers.conf is not world-readable,
starting the podman API service fails. If nothing else, this leaves a
lot of misleading junk in the journal logs.
In practice, only the agent installation method is populating this file,
but in principle this is the right mode wherever it is used. We are
creating the file to work around a podman configuration bug, so it is
entirely possible that other installation methods will also use it in
the future. Therefore the fix is in the bootstrap ignition population
method.